Fix Magento\Sales\Service\V1\ShipmentGetTest::testShipmentGet#15982
Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom Jun 18, 2018
Conversation
4 tasks
22b46d3 to
9e5757d
Compare
Member
Author
|
@vgelani did you run the test after your commit? I'm sorry but your commit introduces several errors:
Moreover the pull request was correct before your commit and reviewed by @maghamed in the msi corresponding pull request. |
This reverts commit 1555b96.
Contributor
|
@slackerzz I have performed these changes which gave errors in travis so I have performed it. |
Contributor
|
Hi @slackerzz. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Related msi pull request: magento-engcom#1350
Manual testing scenarios
Contribution checklist