Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making configurable settings for MAX_IMAGE_WIDTH and MAX_IMAGE_HEIGHT #15941

Closed
wants to merge 1 commit into from

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Jun 7, 2018

Description

It was added a new system fieldset, where the max-width and max-height can be set.
Stores / Configuration / Advanced / System / Images Configuration

So these 2 values are more flexible now for those which need to have bigger images in their shops.

Fixed Issues (if relevant)

  1. \Magento\Framework\Phrase\Renderer\Placeholder::render() can't handle more than 9 placeholders #1374: Wysiwyg > Image Uploader >Max width/height
  2. ...

Manual testing scenarios

  1. Get an image of 3000x700
    https://dummyimage.com/3000x700
  2. Open any wysiwyg editor
  3. Upload an image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


eduard13 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@magento-engcom-team
Copy link
Contributor

Hi @eduard13

Unfortunately, we cannot accept Pull Requests from branches created in magento2 repository.
Please use your own fork as a base for this Pull Request.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants