Skip to content

#4942 and bundle checkbox bug #15905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 3 commits into from
Oct 10, 2018
Merged

#4942 and bundle checkbox bug #15905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c05ac4c
Bundle checkboxes now are checked when item edited from cart
JosephMaxwell Jun 6, 2018
076bb60
#4942: bundled products now retain customer selections when editing f…
JosephMaxwell Jun 6, 2018
e35a9b1
magento/magento2#4942: fix code styles in the app/code/Magento/Bundle…
dmanners Sep 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/code/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,17 @@ public function getJsonConfig()
if ($configValue) {
$defaultValues[$optionId] = $configValue;
}

$preConfiguredQtys = $preConfiguredValues->getData("bundle_option_qty/${optionId}") ?? [];
$selections = $options[$optionId]['selections'];
array_walk($selections, function (&$selection, $selectionId) use ($preConfiguredQtys) {
if (is_array($preConfiguredQtys) && isset($preConfiguredQtys[$selectionId])) {
$selection['qty'] = $preConfiguredQtys[$selectionId];
} else if ((int)$preConfiguredQtys > 0) {
$selection['qty'] = $preConfiguredQtys;
}
});
$options[$optionId]['selections'] = $selections;
}
$position++;
}
Expand Down
4 changes: 3 additions & 1 deletion app/code/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,9 @@ protected function _getSelectedOptions()
*/
protected function assignSelection(\Magento\Bundle\Model\Option $option, $selectionId)
{
if ($selectionId && $option->getSelectionById($selectionId)) {
if (is_array($selectionId)) {
$this->_selectedOptions = $selectionId;
} else if ($selectionId && $option->getSelectionById($selectionId)) {
$this->_selectedOptions = $selectionId;
} elseif (!$option->getRequired()) {
$this->_selectedOptions = 'None';
Expand Down