Skip to content

Remove parameter from method calling#15891

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
saurabh-parekh:saurabh-patch-11
Jun 7, 2018
Merged

Remove parameter from method calling#15891
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
saurabh-parekh:saurabh-patch-11

Conversation

@saurabh-parekh
Copy link
Copy Markdown

@saurabh-parekh saurabh-parekh commented Jun 6, 2018

Remove parameter from method calling

Description

Method definition does not require any parameters. But when it was actually called extra parameter was passed. I remove extra parameter while calling method.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

1 You can check at magento admin panel -> Marketing -> SEO & Search -> URL Rewrites -> Add/Edit with product.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @saurabh-aureate. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants