Skip to content

[Forwardport] Format the javascript code #10#15833

Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
chirag-wagento:2.3-develop-PR-port-14967
Jun 6, 2018
Merged

[Forwardport] Format the javascript code #10#15833
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
chirag-wagento:2.3-develop-PR-port-14967

Conversation

@chirag-wagento
Copy link
Copy Markdown
Contributor

@chirag-wagento chirag-wagento commented Jun 5, 2018

Original Pull Request

#14967

Description

Format the javascript code in the template file.

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Ui labels Jun 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 5, 2018
@magento-engcom-team magento-engcom-team merged commit 8281b38 into magento:2.3-develop Jun 6, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 6, 2018
ENGCOM-1871: [Forwardport] Format the javascript code #10 #15833
c5f9fb4
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 6, 2018

Hi @chirag-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@VladimirZaets VladimirZaets

Labels

Area: Frontend Component: Ui Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@chirag-wagento @magento-engcom-team @VladimirZaets @yogeshsuhagiya