[Backport] Resolve Error While Trying To Load Quote Item Collection Using Magent… #2#15829
Merged
magento-engcom-team merged 2 commits intomagento:2.1-developfrom Jun 13, 2018
neeta-wagento:2.1-develop-PR-port-11869
Merged
[Backport] Resolve Error While Trying To Load Quote Item Collection Using Magent… #2#15829magento-engcom-team merged 2 commits intomagento:2.1-developfrom neeta-wagento:2.1-develop-PR-port-11869
magento-engcom-team merged 2 commits intomagento:2.1-developfrom
neeta-wagento:2.1-develop-PR-port-11869
Conversation
…o\Quote\Model\ResourceModel\QuoteItem\Collection::getItems()
Resolve Space Issue
Contributor
|
Hi @neeta-wagento. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#11869
While Getting Collection of Quote Item using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems() was throwing Fatal error: Uncaught Error: Call to a member function getStoreId() on null in C:\www\magento2\vendor\magento\module-quote\Model\ResourceModel\Quote\Item\Collection.php:98
because of used of injected class.
Description
I have used injected class \Magento\Quote\Model\ResourceModel\Quote\Item\Option\CollectionFactory's getStoreId() method.
It seems working fine with Load Quote Item Collection using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems()
$quoteItemCollection = $this->quoteItemCollectionFactory->create()->getItems();
Fixed Issues (if relevant)
magento/magento2#<8954>: Error While Trying To Load Quote Item Collection Using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems() Error While Trying To Load Quote Item Collection Using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems() #8954
. https://github.com/magento/magento2/issues/8954
Manual testing scenarios
It will return array as expected result.
Contribution checklist