Skip to content

Fixed set template syntax issue#15825

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
sanganinamrata:nps-coding-fix-2
Jun 6, 2018
Merged

Fixed set template syntax issue#15825
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
sanganinamrata:nps-coding-fix-2

Conversation

@sanganinamrata
Copy link
Copy Markdown
Member

Description

I have added module name on a template file as per Magento standard coding format.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

I have changed all Magneto Bundle module template. so You can check after login on Magento Dashboard.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sanganinamrata
Copy link
Copy Markdown
Member Author

@chirag-wagento This pull request doesn't merge yet. Are you hurry to create forward/backword pull request?
I will create forward/backword pull request after merge my this request.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @namratachangani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants