[Backport] fix typo for setCateroryIds#15814
Merged
magento-engcom-team merged 1 commit intomagento:2.1-developfrom Jun 5, 2018
Merged
[Backport] fix typo for setCateroryIds#15814magento-engcom-team merged 1 commit intomagento:2.1-developfrom
magento-engcom-team merged 1 commit intomagento:2.1-developfrom
Conversation
orlangur
approved these changes
Jun 5, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
Contributor
|
Hi @viral-wagento. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15621
Description
Browsing through the source code, we found occurences of the word "Caterory" in tests, which seemed as if it would be a typo. Please have a look - and just close it, if we are wrong. ;) Thank you!!!
Fixed Issues (if relevant)
Manual testing scenarios
Browse to https://github.com/magento/magento2/search?q=setcateroryids&unscoped_q=setcateroryids
Expected result
Actual result
Contribution checklist