Skip to content

[Forwardport 2.3] Trim username on customer account login page#15773

Closed
vijay-wagento wants to merge 3 commits intomagento:2.3-developfrom
vijay-wagento:2.3-develop-PR-port-15365
Closed

[Forwardport 2.3] Trim username on customer account login page#15773
vijay-wagento wants to merge 3 commits intomagento:2.3-developfrom
vijay-wagento:2.3-develop-PR-port-15365

Conversation

@vijay-wagento
Copy link
Copy Markdown

Original Pull Request

#15365

Trim email address on customer account login page generally when copy and paste.

Description

Trim email address by remove leading or trailing space on the customer account login page email field.

Fixed Issues (if relevant)

  1. IE11 user login email validation fails if field has leading or trailing space #6058: IE11 user login email validation fails if field has leading or trailing space

Manual testing scenarios

  1. Open customer account login page in Firefox or IE browser.
  2. Try to add space before entering an email address in the Email field.
  3. Copy " johndoe@domain.com " and paste in the Email field. It will automatically remove leading or trailing space.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dankhrapiyush
Copy link
Copy Markdown
Contributor

@vijay-wagento I will create a [Forwardport 2.3] PR after figuring out Backport issue.
Thank you.

@vijay-wagento
Copy link
Copy Markdown
Author

Hello @dankhrapiyush ,
There is no relation between backport and forward port PR.
Let me know if you need any help from my side for backport issue.
Thanks,

@dankhrapiyush
Copy link
Copy Markdown
Contributor

@vijay-wagento I think the best practice is to create backword/forward ports of PRs by authors.
And also do not create backword/forward ports of PRs until corresponding PRs are merged into 2.2-develop.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Frontend Component: Customer Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants