[Backport] 2.1 develop pr port 15566#15760
Closed
gelanivishal wants to merge 4 commits intomagento:2.1-developfrom
Closed
[Backport] 2.1 develop pr port 15566#15760gelanivishal wants to merge 4 commits intomagento:2.1-developfrom
gelanivishal wants to merge 4 commits intomagento:2.1-developfrom
Conversation
orlangur
approved these changes
Jun 14, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
Contributor
|
Hi @vgelani , we can't reproduce the described issue on vanilla 2.1-develop. Please, verify issue steps and update PR description if needed. |
Contributor
Author
|
@sidolov Yes. I can't produce issue but this PR also fixed the coding standard issue. |
Contributor
|
@vgelani , I'm closing this PR as not relevant. Please, deliver coding standards fixes in the scope of another pull request or create new. Thank you for collaboration! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15566
Fix for #15565
Description
Simple Fix
Fixed Issues (if relevant)
Fix for #15565
Manual testing scenarios
See Ticket
Contribution checklist