Skip to content

[Backport] 2.1 develop pr port 15566#15760

Closed
gelanivishal wants to merge 4 commits intomagento:2.1-developfrom
gelanivishal:2.1-develop-PR-port-15566
Closed

[Backport] 2.1 develop pr port 15566#15760
gelanivishal wants to merge 4 commits intomagento:2.1-developfrom
gelanivishal:2.1-develop-PR-port-15566

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

Original Pull Request

#15566

Fix for #15565

Description

Simple Fix

Fixed Issues (if relevant)

Fix for #15565

Manual testing scenarios

See Ticket

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur assigned orlangur and unassigned VladimirZaets Jun 14, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jun 14, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2000 has been created to process this Pull Request

@sidolov
Copy link
Copy Markdown
Contributor

sidolov commented Jun 15, 2018

Hi @vgelani , we can't reproduce the described issue on vanilla 2.1-develop. Please, verify issue steps and update PR description if needed.

@gelanivishal
Copy link
Copy Markdown
Contributor Author

@sidolov Yes. I can't produce issue but this PR also fixed the coding standard issue.

@sidolov
Copy link
Copy Markdown
Contributor

sidolov commented Jun 18, 2018

@vgelani , I'm closing this PR as not relevant. Please, deliver coding standards fixes in the scope of another pull request or create new. Thank you for collaboration!

@sidolov sidolov closed this Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants