[Forwardport] Move buttons definition to separate file#15757
Merged
magento-engcom-team merged 6 commits intomagento:2.3-developfrom Jun 5, 2018
Merged
[Forwardport] Move buttons definition to separate file#15757magento-engcom-team merged 6 commits intomagento:2.3-developfrom
magento-engcom-team merged 6 commits intomagento:2.3-developfrom
Conversation
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 5, 2018
Contributor
|
Hi @vijay-wagento. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15194
When trying to add new buttons with new actions (besides
reset,saveandsaveAndContinue) to a UiComponent form in the backend, it is needed to extend upon at least 2 files:Magento_Ui/js/form/adapterandMagento_Ui/js/form/form. The second file is easily extendable using mixins, but the first one is not: Mainly because thebuttonsdefinition is based on a local variable. This PR fixes this by moving thebuttonsdefinition in a separate file.Description
This PR adds a new file
buttons.jsthat is called for inadapterso that someone could create a mixin like follows:RequireJS configuration:
And in
Foo_Bar/js/form/form-mixin:Unfortunately, this PR does not deal with how to use
foobarin the end, which is hugely complex.Manual testing scenarios
SaveandSave And Continueare still working in the backendContribution checklist