Skip to content

[Forwardport] set correct annotation#15667

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
gelanivishal:2.3-develop-PR-port-15602
Jun 2, 2018
Merged

[Forwardport] set correct annotation#15667
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
gelanivishal:2.3-develop-PR-port-15602

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

@gelanivishal gelanivishal commented Jun 1, 2018

Original Pull Request

#15602

Description

Set correct annotation to formatDateTime function in lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php file

Fixed Issues (if relevant)

  1. Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php #15601: Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php

Manual testing scenarios

  1. Please review lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php
  2. Please review lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants