Skip to content

[Forwardport] chore: remove extraneous cursor property#15659

Merged
magento-engcom-team merged 1 commit into2.3-developfrom
unknown repository
Jun 2, 2018
Merged

[Forwardport] chore: remove extraneous cursor property#15659
magento-engcom-team merged 1 commit into2.3-developfrom
unknown repository

Conversation

@DanielRuf
Copy link
Copy Markdown
Contributor

Original Pull Request

#15305

Description

cursor is not usable with pointer-events: none. Also this would add the not-allowed cursor which does not make much sense imho.

Manual testing scenarios

  1. create a button with the disabled property
  2. hover and click it
  3. there is no not-allowed cursor

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented Jun 1, 2018

CLA assistant check
All committers have signed the CLA.

@VladimirZaets VladimirZaets self-assigned this Jun 1, 2018
@DanielRuf
Copy link
Copy Markdown
Contributor Author

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Huh? I already did this before. Is this a new bot?

@VladimirZaets
Copy link
Copy Markdown
Contributor

@DanielRuf It's our old bot))))) We had temporary problem with CLA check tool.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @DanielRuf. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@DanielRuf DanielRuf deleted the 2.3-develop-PR-port-15305 branch June 2, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants