Skip to content

[Forwardport] Fixes in config module#15649

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
mhauri:2.3-develop-PR-port-15511
Jun 6, 2018
Merged

[Forwardport] Fixes in config module#15649
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
mhauri:2.3-develop-PR-port-15511

Conversation

@mhauri
Copy link
Copy Markdown

@mhauri mhauri commented Jun 1, 2018

Original Pull Request

#15511

Description

This PR fixes two issues in the Magento/Config Module:

  1. The method Magento/Config/Test/Unit/Block/System/Config/Form/Field/ImageTest.php::testGetElementHtmlWithValue() references to a invalid Backend Model on line 75

  2. The anonymous function has an unused use $data in Magento/Config/Model/Config/Importer.php on line 127

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented Jun 1, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants