Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert long form tags with echo to use short-echo tags #1563

Merged
merged 8 commits into from
Jun 30, 2017
Merged

Convert long form tags with echo to use short-echo tags #1563

merged 8 commits into from
Jun 30, 2017

Commits on Jun 9, 2017

  1. Convert long form tags with echo to short-echo tags 

    Also unify existing short-echo padding. Resolves magento#107. PR magento#1563.
    @davidalger
    davidalger committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    01e9cb4 View commit details
    Browse the repository at this point in the history

  2. Added static test to enforce short-echo tags

    @davidalger
    davidalger committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    702a928 View commit details
    Browse the repository at this point in the history

  3. Renamed test mock files to use extension not matched by convert-tags … 

    …script
    @davidalger
    davidalger committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    8688e99 View commit details
    Browse the repository at this point in the history

  4. Convert long form tags with echo to use short-echo tags magento#1563 

    Updated usages which contained the /* @escapeNotVerified */ comment
    @davidalger
    davidalger committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    69b5527 View commit details
    Browse the repository at this point in the history

  5. Convert long form tags with echo to use short-echo tags magento#1563 

    Caught another variant of these; added wildcard @comment to regex
    @davidalger
    davidalger committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    c03b511 View commit details
    Browse the repository at this point in the history

  6. Convert long form tags with echo to use short-echo tags magento#1563 

    Manual short-echo tag updates for echo calls script didn't catch; sniff did though!
    @davidalger
    davidalger committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    48bd391 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2017

  1. Merge remote-tracking branch 'upstream/develop' into feature/short-ec… 

    …ho-tags
    @davidalger
    davidalger committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    a3ee58a View commit details
    Browse the repository at this point in the history

  2. Convert long form tags with echo to short-echo tags magento#1563 

    Updated templates altered in merge of upstream/develop.
    @davidalger
    davidalger committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    a626c36 View commit details
    Browse the repository at this point in the history