Skip to content

[2.3] [improvement] Swatches LESS rewrite#15624

Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
Karlasa:swatches-less
Jul 5, 2018
Merged

[2.3] [improvement] Swatches LESS rewrite#15624
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
Karlasa:swatches-less

Conversation

@Karlasa
Copy link
Copy Markdown
Contributor

@Karlasa Karlasa commented May 31, 2018

Rewrote LESS code to suit better with Magento LESS mixins and variables.

Fixed Issues (if relevant)

File was missing LESS variables

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Rewrote LESS code to suit better with Magneto Blank theme
@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented May 31, 2018

CLA assistant check
All committers have signed the CLA.

Karlasa added 2 commits June 7, 2018 16:40
Replaced loading gif with Theme loader gif.
Replaced with Theme loader
@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi, @Karlasa, I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @Karlasa. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@Karlasa Karlasa deleted the swatches-less branch August 17, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants