[2.3] [improvement] Swatches LESS rewrite#15624
Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom Jul 5, 2018
Karlasa:swatches-less
Merged
[2.3] [improvement] Swatches LESS rewrite#15624magento-engcom-team merged 3 commits intomagento:2.3-developfrom Karlasa:swatches-less
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
Karlasa:swatches-less
Conversation
Rewrote LESS code to suit better with Magneto Blank theme
Contributor
Replaced loading gif with Theme loader gif.
Replaced with Theme loader
Contributor
|
Hi, @Karlasa, I took your PR into processing, thank you for collaboration. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 5, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 5, 2018
Contributor
|
Hi @Karlasa. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote LESS code to suit better with Magento LESS mixins and variables.
Fixed Issues (if relevant)
File was missing LESS variables
Contribution checklist