Fixes in ui module#15512
Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom May 27, 2018
mhauri:fixes-in-ui-module
Merged
Fixes in ui module#15512magento-engcom-team merged 2 commits intomagento:2.2-developfrom mhauri:fixes-in-ui-module
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
mhauri:fixes-in-ui-module
Conversation
added 2 commits
May 25, 2018 08:38
…ed with 3 parameters, 2 required.
Member
|
Hi @mhauri , |
Contributor
|
Hi @mhauri. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two issues in the Magento/Ui Module:
getConfiguration()invoked with 1 parameter, 0 required, seeMagento/Ui/Component/Bookmark.phpon line 85 and 89Class
Magento\Ui\Component\Control\ActionPoolconstructor invoked with 3 parameters, 2 required. seeMagento/Ui/Test/Unit/Component/Control/ActionPoolTest.phpon line 87Contribution checklist