Issue 15469: Javascript error dropdowns.js#15499
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom May 27, 2018
Merged
Issue 15469: Javascript error dropdowns.js#15499magento-engcom-team merged 1 commit intomagento:2.2-developfrom
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
Conversation
Fixes Javascript error in dropdowns.js by properly initializing the el variable. options.autoclose can now be set to false
Contributor
Contributor
|
@brian-labelle thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Contributor
|
Hi @brian-labelle. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Javascript error in dropdowns.js by properly initializing the el variable. options.autoclose can now be set to false
Description
Initialize the
elvariable outside of the condition checking foroptions.autoclose === trueFixed Issues
Manual testing scenarios
autoclose: falseContribution checklist