Fix HTML syntax in report.phtml error template#15454
Fix HTML syntax in report.phtml error template#15454magento-engcom-team merged 1 commit intomagento:2.2-developfrom
Conversation
Added missing quotes to the div tags with class "control".
|
Hi @abcpremium! Thanks for the PR! I can see the quotes are missing in the 2.3-develop branch as well. Once this PR is done it would be great to apply the same in the 2.3 branch (if you like). |
|
Hi @avoelkl, thank you for the review. |
|
@abcpremium thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
Hey @avoelkl, thanks for accepting the PR. However, this is my first PR ever, so when you say I should do this for 2.3-develop also, do you mean the exact same procedure as this one? Or can I "modify" this PR to include both 2.2-develop and 2.3-develop? Sorry for this stupid question shame on me |
|
Hi @abcpremium, |
|
Actually there is a tool for porting changes here: https://github.com/magento/magento2/wiki/Simple-way-to-port-your-solutions-automatically. I haven't tried it myself but if you want to give it a try I am sure we can find someone to help with this. |
|
Hi @abcpremium. Thank you for your contribution. Please, consider porting this solution across release lines. |
|
@avoelkl Alright I used the tool to port my changes to 2.3-develop. Really easy to use it, nice! |
Added missing quotes to the div tags with class
control.Description
Added missing quotes to the class attribute of div tags in the default reporting template file in pub/errors/default/report.phtml
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist