Skip to content

Refactor JavsScript for UrlRewrite module edit page#15422

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
patelnimesh1988:nimesh-patch-3
May 25, 2018
Merged

Refactor JavsScript for UrlRewrite module edit page#15422
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
patelnimesh1988:nimesh-patch-3

Conversation

@patelnimesh1988
Copy link
Copy Markdown
Contributor

Refactor JavaScript for admin module URL rewrite edit page

Description

Refactor JavaScript for admin module URL rewrite edit page

Fixed Issues (if relevant)

  1. Refactore javascript for module URL rewrite #15356: Refactore javascript for module URL rewrite

Manual testing scenarios

  1. Go to Marketing > URL Rewrites > Edit
  2. Remove Request Path text box value and try to save it.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi, @patelnimesh1988, I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @patelnimesh1988. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants