Fix for Magnifier in inside mode#15382
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom May 27, 2018
kacperchara:bugfix/magnifier-does-not-work-with-mode-set-to-inner
Merged
Fix for Magnifier in inside mode#15382magento-engcom-team merged 1 commit intomagento:2.2-developfrom kacperchara:bugfix/magnifier-does-not-work-with-mode-set-to-inner
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
kacperchara:bugfix/magnifier-does-not-work-with-mode-set-to-inner
Conversation
Contributor
Author
|
There is a problem with the license, although I signed it, it is still visible that the license has not been signed. |
Contributor
|
Hi @kacperchara it seems you committed with one user (https://github.com/kcharadivante) but are logged in and so signed the cla with another user (https://github.com/kacperchara) |
Contributor
|
Hi @kacperchara. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This was referenced Jun 4, 2018
|
I am on 2.2.6 and still having this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issues
Manual testing scenarios
You need to change the magnifier's configuration options in the file: app/design/frontend/Magento/luma/etc/view.xml
Set the following values for these lines: