Skip to content

Refactor javascript code of button split widget#15351

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
amittiwari024:amittiwari024-patch-2
May 22, 2018
Merged

Refactor javascript code of button split widget#15351
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
amittiwari024:amittiwari024-patch-2

Conversation

@amittiwari024
Copy link
Copy Markdown
Contributor

@amittiwari024 amittiwari024 commented May 19, 2018

Refactor javascript code of button split widget call js component

Description

Format the javascript code in the template file spli.phtml for button widget

Fixed Issues (if relevant)

  1. Issue Number Refactor javascript code of button split widget call js component #15354

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi, @amittiwari024, I took your PR into processing, thank you for collaboration.

@amittiwari024
Copy link
Copy Markdown
Contributor Author

Hi, @VladimirZaets thanks for update

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @amittiwari024. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants