Fixed breadcrumb quote issue in product page #15037

[jignesh-baldha]

Fixed breadcrumb quote issue in product page #15037

Description

I've fixed quote issue in breadcrumb in product view page.

Fixed Issues (if relevant)

1. Product Details Page breadcrumbs cause syntax error on products containing quotes #15037: Product Details Page breadcrumbs cause syntax error on products containing quotes

Manual testing scenarios

1. Add double quote in product name and check breadcrumb in product view page.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[vovayatsyuk]

Please double check if your patch is still needed in develop branch. Double quote was already escaped by code that you’ve removed in this PR. (It was added in recently: #15162)

Additionally, you have removed html escaping. Can you comment on this?

[sidolov]

Hi @jignesh-baldha , during QA activities we found that described issue was fixed in the scope of #15162. Please, verify once again your steps in latest 2.2-develop.

[jignesh-baldha]

@sidolov I've removed deprecated function escapeJsQuote() and used escapeJs() which escape javascript context

[magento-engcom-team]

Hi @jignesh-baldha. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

[DanielRuf]

It is not fixed in 2.2.5.

[ci2014]

I confirm @DanielRuf

It is not fixed yet.

[mohsinahmed22]

I also confirm its not fixed on 2.2.5

[Ctucker9233]

Code looks different in 2.2.7 so, maybe fixed? @magento-engcom-team can you confirm the version this fix was/will be released in?