Skip to content

Function is unnecessarily called multiple time#15346

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
saurabh-parekh:saurabh-patch-2
May 22, 2018
Merged

Function is unnecessarily called multiple time#15346
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
saurabh-parekh:saurabh-patch-2

Conversation

@saurabh-parekh
Copy link
Copy Markdown

@saurabh-parekh saurabh-parekh commented May 19, 2018

Function is unnecessarily called multiple time.

Description

getCurrencySymbolsData() is called multiple times in the same file. Remove the extra call of the same function.

Fixed Issues (if relevant)

Issue Number - #15355

Manual testing scenarios

  1. Check the page. Stores > Currency > Currency Symbols

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @saurabh-aureate. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants