Skip to content

Format the javascript code in Tax module#15343

Merged
magento-engcom-team merged 4 commits intomagento:2.2-developfrom
gelanivishal:magento-jquery-issue
May 22, 2018
Merged

Format the javascript code in Tax module#15343
magento-engcom-team merged 4 commits intomagento:2.2-developfrom
gelanivishal:magento-jquery-issue

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

@gelanivishal gelanivishal commented May 19, 2018

Description

Refactor javascript validate code in Tax module.

Fixed Issues (if relevant)

  1. Reformat the javascript code as per magento standards. #15352: Reformat the javascript code as per magento standards

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal
Copy link
Copy Markdown
Contributor Author

@VladimirZaets Thanks.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants