#12820 - Wrong annotation in _toOptionArray - magento/framework/Data/…#15336
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom May 22, 2018
sanjay-wagento:feature-wrong-annotation-to-option-array
Merged
#12820 - Wrong annotation in _toOptionArray - magento/framework/Data/…#15336magento-engcom-team merged 1 commit intomagento:2.2-developfrom sanjay-wagento:feature-wrong-annotation-to-option-array
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
sanjay-wagento:feature-wrong-annotation-to-option-array
Conversation
…Collection/AbstractDb.php
miguelbalparda
approved these changes
May 21, 2018
magento-engcom-team
added
Release Line: 2.2
Partner: Wagento
Contributor
|
Hi @miguelbalparda, thank you for the review. |
Contributor
|
Hi @sanjay-wagento. Thank you for your contribution. Please, consider porting this solution across release lines. |
4 tasks
This was referenced Jun 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set correct annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php
Description
Set correct annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist