Fix typo in test method's name and test result#15297
Merged
magento-engcom-team merged 4 commits intomagento:2.2-developfrom Jun 7, 2018
Merged
Conversation
Contributor
|
Hello @dmytro-ch. Thank you for your collaboration. To preserve backward compatibility, it's prohibited to remove existing public or protected methods. Check https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html#php for the details. You can mark the old method as @deprecated, create a new one and proxy invoking of the new method in the old one. |
…result-value # Conflicts: # dev/tests/functional/tests/app/Magento/Shipping/Test/Constraint/AssertCityBasedShippingRateChanged.php
Contributor
Author
|
@rogyar thank you. I've updated the pull request. |
Contributor
|
Hi @dmytro-ch. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Already fixed in 2.3-develop (as part of #13300), no forwardport needed.
Description
Fix typo in test method's name and in a test result
Contribution checklist