fix: support multiple minisearch widget instances#15284
fix: support multiple minisearch widget instances#15284DanielRuf wants to merge 1 commit into2.2-developfrom unknown repository
Conversation
|
Hi @DanielRuf thank you for this PR. I have restarted the travis build to see if I can find the issue with it. After that I will process your PR. |
|
It seems Travis tries to clone from origin.
|
|
The issue was that Travis seems to reuse the commit hash and I've cherry-picked the commit (accidentally pushed it magento/magento2) so I've created a new PR (to clean it a bit up) and changed the commit hash with a new empty commit and |
|
See #15485 |
|
Interesting thanks for looking at it @DanielRuf |
Description
When cloning the minisearch widget and changing the ID's and selectors they still trigger all instances as the label searchLabel is globally searched instead of in the form.
Manual testing scenarios
Contribution checklist