[fix] typo in method name _exportAddress[s]es#15275
Conversation
|
Hi @miguelbalparda, thank you for the review. |
miguelbalparda
left a comment
There was a problem hiding this comment.
Protected methods cannot be removed, please check https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html
|
@miguelbalparda I've added the deprecated notice in commit: 1a0c8e5 |
|
Hi @DanielRuf, I saw you approved quite a few PRs. We try to reserve this for maintainers, in the future feel free to add +1 or emoji answers instead of that. Thanks! |
Ok, understood. Did not know this. Sorry. |
|
Hi @miguelbalparda, thank you for the review. |
|
Hi @mhauri. Thank you for your contribution. Please, consider porting this solution across release lines. |
Description
Method name
\Magento\Paypal\Model\Api\Nvp::_exportAddresssescontained typoRenamed it to
_exportAddresses.Contribution checklist