Skip to content

Fix Magento_ImportExport not supporting unicode characters in column names#15197

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
tdgroot:import_unicode_columns
May 16, 2018
Merged

Fix Magento_ImportExport not supporting unicode characters in column names#15197
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
tdgroot:import_unicode_columns

Conversation

@tdgroot
Copy link
Copy Markdown
Member

@tdgroot tdgroot commented May 14, 2018

Description

Column names like vitamin_a_µg were being marked invalid.

Manual testing scenarios

  1. Import a catalog product csv with a column like vitamin_a_µg

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi, @tdgroot , I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @tdgroot. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants