Skip to content

[Forwardport] Fixed js error when product has double quote in its name#15186

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
mzeis:2.3-develop-PR-port-15162
May 17, 2018
Merged

[Forwardport] Fixed js error when product has double quote in its name#15186
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
mzeis:2.3-develop-PR-port-15162

Conversation

@mzeis
Copy link
Copy Markdown
Contributor

@mzeis mzeis commented May 13, 2018

Original Pull Request

#15162

Description

Magento 2.2.4 only.
When a product has " symbol in its name - js error appears on the page.

Manual testing scenarios

  1. Add " to the product name in the backend.
  2. Open this product on the frontend.
  3. Breadcrumbs are missing and product image block is not initialized. Console has the following error:
Uncaught SyntaxError: Unexpected string in JSON at position ..

screen shot 2018-05-11 at 10 03 46 pm

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi, @mzeis, I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @mzeis. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants