Skip to content

Fix unnecessary recalculation of product list pricing#15089

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
Jeroenll:patch-2
May 22, 2018
Merged

Fix unnecessary recalculation of product list pricing#15089
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
Jeroenll:patch-2

Conversation

@Jeroenll
Copy link
Copy Markdown
Member

@Jeroenll Jeroenll commented May 9, 2018

Description

Unnecessary recalculation of large product list pricing causes huge slowdowns.

Fixed Issues (if relevant)

  1. Unnecessary recalculation of product list pricing causes huge slowdowns #14941: Unnecessary recalculation of product list pricing causes huge slowdowns

Manual testing scenarios

  1. Create a catalog where prices are including tax + prices are shown including tax.
  2. Go to a category page and show 100 products per page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Jeroenll Jeroenll added Release Line: 2.2 partners-contribution Pull Request is created by Magento Partner Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 9, 2018
@miguelbalparda miguelbalparda self-assigned this May 9, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1551 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: H&O Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants