fix: set message-success in setup if we already have the latest version#15012
fix: set message-success in setup if we already have the latest version#15012magento-engcom-team merged 2 commits into2.2-developfrom unknown repository
Conversation
|
Hi, @DanielRuf , I took your PR into processing, thank you for collaboration. |
|
@DanielRuf thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
Hi @VladimirZaets, is there some required commit message style (as I see some PRs with [BUGFIX]) or similar (commitlint / commitizen could be probably helpful + husky or some prepush Git hooks for contributors)? |
|
@DanielRuf Currently, we haven't special required commit message style. Commits only must be accompanied by meaningful commit messages. |
|
Hi @DanielRuf. Thank you for your contribution. |
Description
Currently the upgrade check in the setup uses
message-erroreven if we already have the latest version.how it currently is:

how it should be:

Logic wise it should be message-success in this case instead of message-error as this is not an error and is not what we expect from the UX perspective.
Manual testing scenarios
2.open the upgrade check in the setup
Contribution checklist