Skip to content

Changed the length of the remote_ip field to store ipv6 addresses#14976

Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
georgeschiopu:fix/issue-10395
May 7, 2018
Merged

Changed the length of the remote_ip field to store ipv6 addresses#14976
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
georgeschiopu:fix/issue-10395

Conversation

@georgeschiopu
Copy link
Copy Markdown
Member

@georgeschiopu georgeschiopu commented May 3, 2018

Expands the remote_ip field to 45 characters in both the sales_order and quote tables, to cope with the ipv6 addresses, otherwise they get truncated.

Fixed Issues (if relevant)

  1. REMOTE_IP gets saved partially when using IPV6 #10395 : REMOTE_IP gets saved partially when using IPV6

Manual testing scenarios

  1. trigger a bin/magento setup:upgrade and check both tables mentioned to check for the changes; also, check the versions of the modules in setup_module

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented May 3, 2018

CLA assistant check
All committers have signed the CLA.

@miguelbalparda miguelbalparda self-assigned this May 3, 2018
…nto#10395

Signed-off-by: George Schiopu <george@space48.com>
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 4, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.2 partners-contribution Pull Request is created by Magento Partner labels May 4, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1441 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

@georgeschiopu thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @georgeschiopu. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@miguelbalparda
Copy link
Copy Markdown
Contributor

Thanks @georgeschiopu! Any chance you can backport this to the other branches?

@georgeschiopu
Copy link
Copy Markdown
Member Author

Hi @miguelbalparda , I'll try to do so this week.
Thanks for the review btw, didn't got a chance to thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Space 48 Partner Space48 contribution partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants