Changed the length of the remote_ip field to store ipv6 addresses#14976
Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom May 7, 2018
Merged
Changed the length of the remote_ip field to store ipv6 addresses#14976magento-engcom-team merged 2 commits intomagento:2.2-developfrom
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
Conversation
Contributor
…nto#10395 Signed-off-by: George Schiopu <george@space48.com>
miguelbalparda
approved these changes
May 4, 2018
Contributor
|
Hi @miguelbalparda, thank you for the review. |
Contributor
|
@georgeschiopu thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Contributor
|
Hi @georgeschiopu. Thank you for your contribution. |
Contributor
|
Thanks @georgeschiopu! Any chance you can backport this to the other branches? |
Member
Author
|
Hi @miguelbalparda , I'll try to do so this week. |
This was referenced May 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands the
remote_ipfield to 45 characters in both thesales_orderandquotetables, to cope with the ipv6 addresses, otherwise they get truncated.Fixed Issues (if relevant)
Manual testing scenarios
bin/magento setup:upgradeand check both tables mentioned to check for the changes; also, check the versions of the modules insetup_moduleContribution checklist