Skip to content

FIX for issue#14855 - Adding an * to do a customer search#14905

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
phoenix128:issue-14855-asterisk-on-grid-search
Apr 30, 2018
Merged

FIX for issue#14855 - Adding an * to do a customer search#14905
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
phoenix128:issue-14855-asterisk-on-grid-search

Conversation

@phoenix128
Copy link
Copy Markdown
Contributor

@phoenix128 phoenix128 commented Apr 29, 2018

According to MySQL fulltext documentation, AGAINST values shoud be stripped of special chars if they are not intended to be used.
https://dev.mysql.com/doc/refman/5.5/en/fulltext-search.html
Searching "*" in any grid list causes a 400 error because of no filtering is applied.

Fixed Issues (if relevant)

  1. Adding an * to do a customer search. #14855: Adding an * to do a customer search

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

According to MySQL fulltext documentation, AGAINST values shoud be stripped of special chars if they are not intended to be used
https://dev.mysql.com/doc/refman/5.5/en/fulltext-search.html
Searching "*" in any grid list causes a 400 error because of no filtering is applied.
@phoenix128 phoenix128 changed the title FIX for issue#14855 FIX for issue#14855 - Adding an * to do a customer search Apr 30, 2018
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 30, 2018
@magento-engcom-team magento-engcom-team merged commit 187ab1f into magento:2.2-develop Apr 30, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @phoenix128. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants