Skip to content

Changed return type of addToCartPostParams to array#14876

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
LordZardeck:patch-1
Apr 28, 2018
Merged

Changed return type of addToCartPostParams to array#14876
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
LordZardeck:patch-1

Conversation

@LordZardeck
Copy link
Copy Markdown
Contributor

@LordZardeck LordZardeck commented Apr 26, 2018

Description

\Magento\Catalog\Block\Product\ListProduct::getAddToCartPostParams incorrectly defined a string return type when in fact it's an array

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@LordZardeck
Changed return type of addToCartPostParams to array
17d8cf9 
\Magento\Catalog\Block\Product\ListProduct::getAddToCartPostParams incorrectly defined a string return type when in fact it's an array
@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented Apr 26, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@orlangur orlangur self-assigned this Apr 26, 2018
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 26, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Apr 26, 2018

Hi @orlangur, thank you for the review.
ENGCOM-1403 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Apr 26, 2018

@LordZardeck thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@LordZardeck
Copy link
Copy Markdown
Contributor Author

LordZardeck commented Apr 26, 2018

@magento-engcom-team Joined.

@magento-engcom-team magento-engcom-team merged commit 17d8cf9 into magento:2.2-develop Apr 28, 2018
magento-engcom-team pushed a commit that referenced this pull request Apr 28, 2018
ENGCOM-1403: Changed return type of addToCartPostParams to array #14876
9726e60
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Apr 28, 2018

Hi @LordZardeck. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

This was referenced May 8, 2018
Merged
Merged
@rogyar rogyar mentioned this pull request May 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels

Progress: accept Release Line: 2.2

Projects

None yet

Milestone

April 2018

Development

Successfully merging this pull request may close these issues.

4 participants

@LordZardeck @magento-cicd2 @magento-engcom-team @orlangur