Skip to content

[Forwardport] Invoice grid shows wrong shipping & handling for partial items invoice. It shows order's shipping & handling instead if invoiced shipping& handling charge#14851

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
rostyslav-hymon:2.3-develop-PR-port-14795
Apr 27, 2018

Conversation

@rostyslav-hymon
Copy link
Copy Markdown
Contributor

Original Pull Request

#14795

Description

Preconditions

  1. Magento Version : (2.1.6 | 2.2.0 | 2.2.2 | 2.2.3) (community-edition), (2.2.2 | 2.2.3) (enterprise-edition)
  2. PHP : 7.0.24
  3. MySQL : 5.7.21
  4. Platform : MacOS High Sierra v10.13.4

Fixed Issues

  1. Invoice grid shows wrong shipping & handling for partial items invoice. It shows order's shipping & handling instead if invoiced shipping& handling charge

Manual testing scenarios

  1. Place order with multiple taxable items and shipping charge
  2. Generate separate invoice for each items and shipping charge should be covered in first invoice. (In short generate multiple invoices for same order with different items)
  3. Do check value of Shipping & Handling column value in Invoice grid.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

 from. Changed from sales_order to sales_invoice
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 25, 2018
@magento-engcom-team magento-engcom-team merged commit 17907fc into magento:2.3-develop Apr 27, 2018
magento-engcom-team pushed a commit that referenced this pull request Apr 27, 2018
…ng for partial items invoice. It shows order's shipping & handling instead if invoiced shipping& handling charge #14851
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rostyslav-hymon. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants