Skip to content

Add default schedule config for sitemap_generate job #14822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 3 commits into from
Apr 28, 2018
Merged

Add default schedule config for sitemap_generate job #14822

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9463c77
Add default schedule config for sitemap_generate job
Apr 23, 2018
d95f044
Cleanup
Apr 24, 2018
a065434
Fixup
Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/code/Magento/Sitemap/Model/Observer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ class Observer
*/
const XML_PATH_GENERATION_ENABLED = 'sitemap/generate/enabled';

/**
* Cronjob expression configuration
*/
const XML_PATH_CRON_EXPR = 'crontab/default/jobs/generate_sitemaps/schedule/cron_expr';

@ishakhsuvarov ishakhsuvarov Apr 24, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to deprecate this instead of removing

@jameshalsall jameshalsall Apr 24, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree, but a) Magento does not follow semantic versioning between marketing releases and b) it points at the wrong config path so it's incredibly unlikely this is used anywhere directly.

@ishakhsuvarov ishakhsuvarov Apr 24, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any way it is better to stay on a safe side and follow conventions where possible.


/**
* Error email template configuration
*/
Expand Down
11 changes: 11 additions & 0 deletions app/code/Magento/Sitemap/etc/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,16 @@
</valid_paths>
</file>
</sitemap>
<crontab>
<default>
<jobs>
<sitemap_generate>
<schedule>
<cron_expr>0 0 * * *</cron_expr>
</schedule>
</sitemap_generate>
</jobs>
</default>
</crontab>
</default>
</config>