Skip to content

#14669 Css class "empty" is always present on minicart dropdown#14715

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
Karlasa:issue-14669
Apr 17, 2018
Merged

#14669 Css class "empty" is always present on minicart dropdown#14715
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
Karlasa:issue-14669

Conversation

@Karlasa
Copy link
Copy Markdown
Contributor

@Karlasa Karlasa commented Apr 16, 2018

Description

Removed class "empty". It was shown even if there was products in cart. As there was nothing connected with it, i supose it can be removed.

Fixed Issues (if relevant)

  1. Css class "empty" is always present on minicart dropdown  #14669: Css class "empty" is always present on minicart dropdown

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @Karlasa. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants