[2.2] Optimize ID to SKU lookup of tier prices#14699
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom Apr 27, 2018
Merged
[2.2] Optimize ID to SKU lookup of tier prices#14699magento-engcom-team merged 1 commit intomagento:2.2-developfrom
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
Conversation
Previously, with a large number of tier or group prices, each tier would separately make a database query to lookup the associated SKU. This instead load the ID to SKU mapping once, and uses it for all tiers. When lookup up a batch of 100 SKUs with hundreds of tier prices per SKU, this cuts lookup time from on the order of 4s to on the order of 0.1s or less.
4 tasks
Contributor
Contributor
|
Hi @toddbc let me run some tests on this PR and try to process this. If I need anything I will get back to you here about it. Also thank you for the forward at #14700 I will process the 2.2 version first and then once that is complete move onto the 2.3 version so that the process flow is a little smoother. Feel free to reach out to me if you have any questions. |
Contributor
Author
|
Thanks - already accepted. |
Contributor
|
Hi @toddbc. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, with a large number of tier or group prices, each tier would separately make a database query to lookup the associated SKU.
This instead load the ID to SKU mapping once, and uses it for all tiers.
When lookup up a batch of 100 SKUs with hundreds of tier prices per SKU, this cuts lookup time from on the order of 4s to on the order of 0.1s or less.
When editing a B2B shared catalog with many assigned products that have many associated tiered pricing rules, this results in a 50% decrease in load time.
Fixed Issues (if relevant)
Cloud 77962 is not fixed, but is improved.
Manual testing scenarios
Note: there should be no functional change with this PR, except that with hundreds of shared catalogs and thousands of products, editing shared catalogs (as well as other operations) should be faster.
Contribution checklist