Add Parent Item to order item in repository#14614
Merged
magento-engcom-team merged 1 commit intoMay 16, 2018
Merged
Conversation
4 tasks
Contributor
|
Hi @JeroenVanLeusden, |
Member
Author
|
Sure, hopefully have some time by end of this week. Will ping you when ready. Edit: |
Contributor
|
@JeroenVanLeusden I think good option there will be adding new integration test that will check after getting parent item is present |
Member
Author
|
Have time by end of the week to update the PR, just so you know ;) |
a5f2b6c to
f121e1c
Compare
Member
Author
|
@ihor-sviziev PR is updated with test. |
ihor-sviziev
approved these changes
May 12, 2018
Contributor
|
Hi @ihor-sviziev, thank you for the review. |
Contributor
|
Hi @JeroenVanLeusden. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
GET /V1/orders/items/{id}the parent item isn't set. This PR will add the parent item if theparent_item_idis set.Fixed Issues (if relevant)
Manual testing scenarios
GET /V1/orders/items/{id}.parent_item_idis set butparent_itemisn't.Contribution checklist