Skip to content

[Forwardport] Fix issue #13010. Check if product is assigned to current website.#14528

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
namlier:2.3-develop-PR-port-14360
Apr 5, 2018
Merged

[Forwardport] Fix issue #13010. Check if product is assigned to current website.#14528
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
namlier:2.3-develop-PR-port-14360

Conversation

@namlier
Copy link
Copy Markdown
Contributor

@namlier namlier commented Apr 4, 2018

Original Pull Request

#14360

Description

Checking if product is assigne to current website, before displaying "Write a review page".

Fixed Issues (if relevant)

  1. Write a Review page works on multistore for products that are not assigned to that store #13010: Write a Review page works on multistore for products that are not assigned to that store

Manual testing scenarios

  1. Create an additional Website and Storefront e.g. http://www.store1.com/ and http://www.store2.com/
  2. Create a product that is assigned to website 1 only
  3. Ensure http://www.store1.com/catalog/product/view/id/1 shows up correctly and http://www.store2.com/catalog/product/view/id/1 throws a 404.
  4. Navigate directly to the /review/product/list/id/1 page on store 2 (http://www.store2.com/review/product/list/id/1)
  5. Page 404 should be displayed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants