Skip to content

[Forwardport] Correct function return statement.#14499

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
namlier:2.3-develop-PR-port-14466
Apr 4, 2018
Merged

[Forwardport] Correct function return statement.#14499
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
namlier:2.3-develop-PR-port-14466

Conversation

@namlier
Copy link
Copy Markdown
Contributor

@namlier namlier commented Apr 3, 2018

Original Pull Request

#14466
The return statement should say $this instead of this.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 3, 2018
@magento-engcom-team magento-engcom-team merged commit c8af5d6 into magento:2.3-develop Apr 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Apr 4, 2018
ENGCOM-1214: [Forwardport] Correct function return statement. #14499
badd531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sidolov sidolov

Labels

Progress: accept Release Line: 2.3

Projects

None yet

Milestone

April 2018

Development

Successfully merging this pull request may close these issues.

4 participants

@namlier @sidolov @magento-engcom-team @sanganinamrata