magento/magento2#12362 [2.2] Do not remove session instantly#14487
Closed
swnsma wants to merge 4 commits intomagento:2.2-developfrom
swnsma:magento#12362-SessionId-Lost-After-Multiple-Reloads-2.2
Closed
magento/magento2#12362 [2.2] Do not remove session instantly#14487swnsma wants to merge 4 commits intomagento:2.2-developfrom swnsma:magento#12362-SessionId-Lost-After-Multiple-Reloads-2.2
swnsma wants to merge 4 commits intomagento:2.2-developfrom
swnsma:magento#12362-SessionId-Lost-After-Multiple-Reloads-2.2
Conversation
4 tasks
added 4 commits
April 6, 2018 23:29
Give configurable time delay to capture session id. Remove old sessions only after new session id cookie was received. (cherry picked from commit dd7e7e9)
(cherry picked from commit 3bb19ea)
Move session calls to separated and shared session storage. Suppress Warnings. (cherry picked from commit 088a836)
Remove changing of configureation settings. Adjust session forwarding.
Contributor
|
Closing in favor of implementation which is going to be provided by core team: #14428 (comment) @swnsma thanks for collaboration! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give configurable time delay to capture session id.
Remove old sessions only after new session id cookie was received.
Description
Current pull request contains fix for the issue #12362.
Problem related to specific case of session work in PHP.
In case of call function 'session_regenerate_id(true)' there is required to be sure that renewed cookie will be successfully delivered to the browser.
Current PR provide functionality to keep old session till customer will not receive cookie.
Fixed Issues
Manual testing scenarios
Pre-Conditions
Steps to reproduce
Expected result
Actual result
Contribution checklist