[Improvement] Implement design theme grid on ui component#14470
[Improvement] Implement design theme grid on ui component#14470magento-engcom-team merged 10 commits intomagento:2.3-developfrom
Conversation
|
Hi @simpleadm , any updates? |
|
Hi @VladimirZaets , |
|
Hi @simpleadm , we have 2 functional tests that were failed with your changes. That's are |
|
@magento-engcom-team give me new test instance |
|
Hi @VladimirZaets. Thank you for your request. I'm working on Magento instance for you |
|
Hi @VladimirZaets, here is your new Magento instance. |
|
Hi @VladimirZaets , |
| * Theme grid collection | ||
| */ | ||
| class Collection extends \Magento\Theme\Model\ResourceModel\Theme\Collection | ||
| class Collection extends ThemeCollection implements SearchResultInterface |
There was a problem hiding this comment.
Hi @simpleadm, please make some refactoring:
- The collection shouldn't extend the ThemeCollection collection, it should only implement SearchResultInterface.
- Use ThemeCollection to getting access to data inside implemented methods.
|
Hi @VladimirZaets , |
|
Hi @simpleadm, thanks, I took this PR in progress. |
|
Hi @simpleadm. The grid rows are not clickable, consequently, edit page is not available too. |
|
Hi @VladimirZaets , |
- Make $urlBuilder private, update doc block
|
Hi @simpleadm. |
|
Hi @VladimirZaets , |
…#14470 (fix grid class and test)
|
Hi @simpleadm. Thank you for your contribution. |
Description
Several versions ago backend grid widgets (
\Magento\Backend\Block\Widget\Grid) were marked asdeprecated in favour of UI component implementation. This PR refactors design theme grid to use UI components.
Grid location: Content > Design > Themes
At least it will save time of third party developers who needs to extend themes grid :)
Manual testing scenarios
Before changes:

After changes:

Contribution checklist