[Forwardport] precision for price overriding by js#14461
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Apr 5, 2018
namlier:2.3-develop-PR-port-14350
Merged
[Forwardport] precision for price overriding by js#14461magento-engcom-team merged 1 commit intomagento:2.3-developfrom namlier:2.3-develop-PR-port-14350
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
namlier:2.3-develop-PR-port-14350
Conversation
orlangur
approved these changes
Mar 31, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#14350
When using more then 2 digits ex(9.4880 will be displayed as 9.49) for the price the js will override this value and it will format using the round for 2 digits.
Preconditions
Steps to reproduce
Expected result
Actual result
Going deeer found the issue in price-utils.js on this line
am.toFixed(2) <--- is using the hardcoded precision and the price will be overrided with 2 digits value !!!
done a quick check and changing this to
seems to do the job.
Fixed Issues (if relevant)
Contribution checklist