Issue 14351: Product import doesn't change Enable Qty Increments field

[simpleadm]

Product import doesn't change Enable Qty Increments field

Description

\Magento\CatalogImportExport\Model\Import\Product::_setStockUseConfigFieldsValues method rely on Use Config Settings property name will be with use_config_ prefix, but for enable_qty_increments filed it is named as use_config_enable_qty_inc.

Fixed Issues (if relevant)

1. Product import doesn't change Enable Qty Increments field #14351: Product import doesn't change Enable Qty Increments field

Steps to reproduce

1. Create simple product with 'Test Simple' SKU
2. Fill Quantity, Stock Status and required fields
3. Make sure that Enable Qty Increments ('Advanced Inventory') marked as Use Config Settings
4. Go to System > Data transfer: Import > Import products
5. Select Import Behavior: Add/Update
6. Use attached csv file

Example files

"sku","qty","manage_stock","enable_qty_increments","qty_increments"
"Test Simple",88,"Use Config",1,2

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[rogyar]

I would suggest using the static definition instead of the hardcoded 'enable_qty_increments' value.

Magento\CatalogInventory\Api\Data\StockItemInterface::ENABLE_QTY_INCREMENTS

[simpleadm]

Thanks for suggestion, it makes sense.
I thought about it, but ignored in favor of consistency, e.g. \Magento\CatalogImportExport\Model\Import\Product::$defaultStockData doesn't use constants etc.

Any way, suggested changes were implemented.

[rogyar]

Hi @simpleadm. There's a merge conflict in one of the files. Please, merge the updated 2.3-develop branch into your branch, resolve conflicts and push once again. Thank you

[simpleadm]

Hi @rogyar ,
Conflicts were resolved.

[simpleadm]

@magento-engcom-team any updates?

[magento-engcom-team]

Hi @simpleadm. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.