Skip to content

Typo in SSL port number#14062

Merged
magento-engcom-team merged 1 commit into
magento:2.2-developfrom
mediact:feature/pub-errors-port-number
Mar 16, 2018
Merged

Typo in SSL port number#14062
magento-engcom-team merged 1 commit into
magento:2.2-developfrom
mediact:feature/pub-errors-port-number

Conversation

@jasperzeinstra
Copy link
Copy Markdown
Contributor

@jasperzeinstra jasperzeinstra commented Mar 12, 2018

Description

SSL is run on port 433, but in pub/errors/processor.php we check for port 433. This looks like a typo. I ran in to this problem when visiting an url of an image that was not on the server. It resulted in a weird base url with the port number 443.

Manual testing scenarios

  1. Make sure your shop runs on SSL
  2. Visit a non existing image: https://www.yourshop.com/media/email/logo/default/logo_default.png
  3. Check the tag in the header

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

@jasperzeinstra thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants