Typo in SSL port number#14062
Merged
magento-engcom-team merged 1 commit intoMar 16, 2018
Merged
Conversation
Contributor
|
@jasperzeinstra thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SSL is run on port 433, but in
pub/errors/processor.phpwe check for port433. This looks like a typo. I ran in to this problem when visiting an url of an image that was not on the server. It resulted in a weird base url with the port number443.Manual testing scenarios
Contribution checklist