[Forwardport] Remove forced setting of cache_lifetime to false in constructor and set default cache_lifetime to 3600#13785
Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom Feb 26, 2018
nmalevanec:2.3-develop-PR-port-13762
Merged
[Forwardport] Remove forced setting of cache_lifetime to false in constructor and set default cache_lifetime to 3600#13785magento-engcom-team merged 2 commits intomagento:2.3-developfrom nmalevanec:2.3-develop-PR-port-13762
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
nmalevanec:2.3-develop-PR-port-13762
Conversation
…et default cache_lifetime to 3600
…et default cache_lifetime to 3600 Unit test.
ihor-sviziev
approved these changes
Feb 22, 2018
Contributor
|
Hi @ihor-sviziev, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 26, 2018
…to false in constructor and set default cache_lifetime to 3600 #13785
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#13762
As noted in issue #13595 the Magento\Theme\Block\Html\Footer block is not saved to cache. This issue has been looked at as part of #MLAU18
Description
In investigating the issue it was found that the footer block does not have a cache lifetime set and it also has code in its constructor to set the cache lifetime to false. This pull request removes the forcing of cache lifetime to false and sets the default value to 3600 as done so in the \Magento\Theme\Block\Html\Topmenu block.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist