Skip to content

Conversation

@Jeroenll
Copy link
Member

@Jeroenll Jeroenll commented Feb 12, 2018

Description

Add web/unsecure/base_url config to website and store scope. Setting is used that way in the code, see:
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Store/App/FrontController/Plugin/RequestPreprocessor.php#L80-L83
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Store/Model/BaseUrlChecker.php#L63-L66

The tests also use store scope.

Fixed Issues (if relevant)

  1. None I could find.

Related Pull Request

#13659

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Feb 14, 2018
@dmanners dmanners added this to the February 2018 milestone Feb 14, 2018
@dmanners
Copy link
Contributor

Hi @JeroenVanLeusden thanks for this PR. I will process this now for you.

@magento-engcom-team magento-engcom-team merged commit 0cb7019 into magento:2.2-develop Feb 15, 2018
@Jeroenll Jeroenll deleted the patch-7 branch March 20, 2018 10:44
@paales paales added Partner: Reach Digital Pull Request is created by partner Reach Digital and removed Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Reach Digital Pull Request is created by partner Reach Digital Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants